Support neovim in vimgolf cli #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The '--nofork' option is invalid for neovim. It is also stated in comment on line 106 that '--nofork' option is only required for gvim. So, it is more logical to have this option for gvim only not for vim or neovim. This code is tested with 'vim', 'neovim' and 'gvim' (vim-gtk3) and it is working without any error.
With the requirement of rake 12.3.1, the cli component can not compile with rvm<2.0.
igrigorik
reviewed
Jun 1, 2018
| @@ -4,8 +4,6 @@ matrix: | |||
| - rvm: 2.4.1 # Test web AND cli with specific version | |||
| gemfile: Gemfile | |||
| # Otherwise test only the cli | |||
| - rvm: 1.9 | |||
There was a problem hiding this comment.
Any particular reason why you removed this?
There was a problem hiding this comment.
Because ruby 1.9 is no more supported https://www.ruby-lang.org/en/news/2015/02/23/support-for-ruby-1-9-3-has-ended/
I m pretty sur it is because since your last merge (upgrade gem) the 1.9 test stopped working because of gem incompatible with r 1.9
|
@mayanksuman thank you for the contribution! |
|
@igrigorik thanks for merging the changes. |
This was referenced Jan 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The '--nofork' option is invalid for neovim.
It is also stated in comment on line 106 that '--nofork' option is only required for gvim.
So, it is more logical to have this option for gvim only not for vim or neovim.
This code is tested with 'vim', 'neovim' and 'gvim' (vim-gtk3) and it is working without any error.
Solves #162